Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model name in example #218

Merged
merged 1 commit into from
May 29, 2024
Merged

Change model name in example #218

merged 1 commit into from
May 29, 2024

Conversation

PicoCentauri
Copy link
Contributor

@PicoCentauri PicoCentauri commented May 29, 2024

This should fix the docs issue. I think "model.pt" is even the better name because for us the suffix .pt means that this is already exported.


📚 Documentation preview 📚: https://metatensor-models--218.org.readthedocs.build/en/218/

Copy link
Collaborator

@frostedoyster frostedoyster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree.
It seems that we have two codecov triggers now?

@PicoCentauri PicoCentauri merged commit b89891e into main May 29, 2024
13 checks passed
@PicoCentauri PicoCentauri deleted the fix-docs branch May 29, 2024 17:00
@PicoCentauri
Copy link
Contributor Author

It seems that we have two codecov triggers now?

Interesting. Lets see in other commits. Maybe it is a bug on their side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants