Dump and load extensions #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/metatensor/models/cli/export.py
Outdated
| @@ -63,4 +63,4 @@ def export_model(model: Any, output: Union[Path, str] = "exported-model.pt") -> | |||
| torch.jit.save(model, path) | |||
| else: | |||
| mts_atomistic_model = model.export() | |||
| mts_atomistic_model.export(path) | |||
| mts_atomistic_model.export(path, collect_extensions="extensions") | |||
There was a problem hiding this comment.
Should we inform the user in the end where the extensions are saved?
Related to #208
There was a problem hiding this comment.
I think this should work now! Very nice @frostedoyster
Maybe add some tests that extensions are saved and loaded correctly, Via CLI and Python would be great.
This was
linked to
issues
May 30, 2024
PicoCentauri
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Can you also add the logger.info referring to the location as in train.
|
@PicoCentauri Now there are tests that both |
PicoCentauri
approved these changes
Jun 3, 2024
| @@ -60,7 +64,10 @@ def export_model(model: Any, output: Union[Path, str] = "exported-model.pt") -> | |||
| path = str(check_suffix(filename=output, suffix=".pt")) | |||
|
|
|||
| if is_exported(model): | |||
| logger.info(f"The model is already exported. Saving it to `{path}`.") | |||
There was a problem hiding this comment.
Cool. I am always struggeling if we should also add a test if these infos are displayed... But I think it is fine for now.
PicoCentauri
pushed a commit
that referenced
this pull request
Jun 4, 2024
PicoCentauri
pushed a commit
that referenced
this pull request
Jun 4, 2024
PicoCentauri
pushed a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #201
📚 Documentation preview 📚: https://metatensor-models--222.org.readthedocs.build/en/222/