-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GAP model #223
Add GAP model #223
Conversation
I had to soft reset the branch due to the history rewrite. Looking for help on how to make @DavideTisi and @agoscinski co-authors of this PR |
When committing you can add them by including |
so now that the "main" branch is in main what is missing to merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work @DavideTisi @agoscinski and @frostedoyster !
Co-authored-by: Philip Loche <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MERGE!!!11!!!
If I understood @frostedoyster correctly we now want to replace the example with the GAP model and train the model directly in CI?
Also do we want to use GAP for the tests of the main library? Should also speed up the tests compared to the BPNN.
Reopening #76
📚 Documentation preview 📚: https://metatensor-models--223.org.readthedocs.build/en/223/