Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add units to logging #256

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Add units to logging #256

merged 9 commits into from
Jun 13, 2024

Conversation

frostedoyster
Copy link
Collaborator

@frostedoyster frostedoyster commented Jun 13, 2024 •
edited
Loading

Adds units to the logs, closes #253.

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

📚 Documentation preview 📚: https://metatrain--256.org.readthedocs.build/en/256/

Luthaf
Luthaf approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@Luthaf Luthaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well! To be merged after rebasing

@frostedoyster frostedoyster merged commit dfd6921 into main Jun 13, 2024
13 checks passed
@frostedoyster frostedoyster deleted the units branch June 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luthaf Luthaf Luthaf approved these changes

@abmazitov abmazitov Awaiting requested review from abmazitov abmazitov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include units in errors wherever possible
2 participants
@frostedoyster @Luthaf