Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat all warnings as errors during core tests (?) #323

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frostedoyster
Copy link
Collaborator

@frostedoyster frostedoyster commented Jul 28, 2024

This treats all warnings as errors during tests, extracted from #315. I don't think it's a good idea to have this for now because it makes it easier for things to break and it will slow down our development


📚 Documentation preview 📚: https://metatrain--323.org.readthedocs.build/en/323/

@frostedoyster frostedoyster marked this pull request as draft July 28, 2024 13:29
@PicoCentauri
Copy link
Contributor

It is only treating warnings as errors in the core part and not in the architectures. Why do you think it will slow down the development?

I think warnings that will be replaced to the users may confuse them even more compared to developers which should fix them.

Also, usual deprecation warnings which should be fixed by us usually get ignored until the feature is gone and errors are raised. I think it only shifts fixing issues to later stages but the work has to be done at some point. See for examples #316. I think we reached a stage were we can treat them as errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants