Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error and logging messages #341

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Improve error and logging messages #341

merged 7 commits into from
Sep 26, 2024

Conversation

Luthaf
Copy link
Member

@Luthaf Luthaf commented Sep 23, 2024

Ref #339

Small improvements to multiple error/logging messages.

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

📚 Documentation preview 📚: https://metatrain--341.org.readthedocs.build/en/341/

@Luthaf Luthaf changed the title Error log messages Improve error and logging messages Sep 23, 2024
Copy link
Contributor

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with all improvements. Maybe we can even help to solve the issue of @bananenpampe.

src/metatrain/utils/data/readers/readers.py Outdated Show resolved Hide resolved
@frostedoyster frostedoyster merged commit ccb5203 into main Sep 26, 2024
11 of 12 checks passed
@frostedoyster frostedoyster deleted the error-log-messages branch September 26, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants