Improve error when architecture deps are missing #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PicoCentauri
force-pushed
the
better-import-error
branch
from
8917a25
to
c2f4970
Compare
Luthaf
approved these changes
Oct 4, 2024
Luthaf
reviewed
Oct 4, 2024
| raise ImportError( | ||
| f"Trying to import '{name}' but architecture dependencies " | ||
| f"seem not be installed. \n" | ||
| f"Try to install them with `pip install .[{name_for_deps}]`" |
There was a problem hiding this comment.
Suggested change
| f"Try to install them with `pip install .[{name_for_deps}]`" | |
| f"Try to install them with `pip install metatrain[{name_for_deps}]`" |
Luthaf
reviewed
Oct 4, 2024
|
|
||
| match = ( | ||
| rf"Trying to import '{name}' but architecture dependencies seem not be " | ||
| rf"installed. \nTry to install them with `pip install .\[{name_for_deps}\]`" |
There was a problem hiding this comment.
Suggested change
| rf"installed. \nTry to install them with `pip install .\[{name_for_deps}\]`" | |
| rf"installed. \nTry to install them with `pip install metatrain\[{name_for_deps}\]`" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when one wants to run an architecture and the dependencies is missing we display the default import error about the missing package. This may not really helpful.
I changed this behavior that users get an error message suggesting to install the specific extras of their architecture.
Contributor (creator of pull-request) checklist
📚 Documentation preview 📚: https://metatrain--350.org.readthedocs.build/en/350/