-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic continuation #363
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f79a36d
Automatic continuation
frostedoyster 3c136bf
Call processing function before new `outputs/` directory is created
frostedoyster 427d3d8
Make it distributed-proof
frostedoyster ed0d8e0
Documentation
frostedoyster 55d3619
Downgrade numpy
frostedoyster 811db9a
Better comment
frostedoyster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -74,7 +74,7 @@ def _add_train_model_parser(subparser: argparse._SubParsersAction) -> None: | |||||
"-c", | ||||||
"--continue", | ||||||
dest="continue_from", | ||||||
type=str, | ||||||
type=_process_continue_from, | ||||||
required=False, | ||||||
help="File to continue training from.", | ||||||
) | ||||||
|
@@ -98,6 +98,29 @@ def _prepare_train_model_args(args: argparse.Namespace) -> None: | |||||
args.options = OmegaConf.merge(args.options, override_options) | ||||||
|
||||||
|
||||||
def _process_continue_from(continue_from: str) -> Optional[str]: | ||||||
# covers the case where `continue_from` is `auto` | ||||||
if continue_from == "auto": | ||||||
# try to find the `outputs` directory; if it doesn't exist | ||||||
# then we are not continuing from a previous run | ||||||
if Path("outputs/").exists(): | ||||||
# take the latest day directory | ||||||
dir = sorted(Path("outputs/").iterdir())[-1] | ||||||
# take the latest second directory | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also the first directory (the "day" directory) is technically "time", I'll make it clearer |
||||||
dir = sorted(dir.iterdir())[-1] | ||||||
# take the latest checkpoint. This cannot be done with | ||||||
# `sorted` because some checkpoint files are named with | ||||||
# the epoch number (e.g. `epoch_10.ckpt` would be before | ||||||
# `epoch_8.ckpt`). We therefore sort by file creation time. | ||||||
new_continue_from = str( | ||||||
sorted(dir.glob("*.ckpt"), key=lambda f: f.stat().st_ctime)[-1] | ||||||
) | ||||||
else: | ||||||
new_continue_from = None | ||||||
|
||||||
return new_continue_from | ||||||
|
||||||
|
||||||
def train_model( | ||||||
options: Union[DictConfig, Dict], | ||||||
output: str = "model.pt", | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should inform the user that the training is continued if the
outputs
directory is found or maybe error or warn if continue="auto" and now directory is found.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! It's now there