Add LoRA fine-tuning for PET #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Comment on lines
+132
to
+133
| else: | ||
| new_continue_from = continue_from |
There was a problem hiding this comment.
Thanks and sorry for the bug!
frostedoyster
approved these changes
Nov 8, 2024
DavideTisi
reviewed
Nov 8, 2024
| What is LoRA? | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| LoRA (Low-Rank Adaptation) is a technique used to adapt pre-trained models |
There was a problem hiding this comment.
Suggested change
| LoRA (Low-Rank Adaptation) is a technique used to adapt pre-trained models | |
| LoRA (Low-Rank Adaptation) Parameter Efficient Fine Tuning (PEFT) is a technique | |
| used to adapt pre-trained models |
I would put also the definition of PEFT only becouse then the name appears in the parameters file, and an user that know nothig can be confused if it is a typo with PET.
There was a problem hiding this comment.
Yes I agree, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the LoRA fine-tuning functionality to PET model. Also closes the issues: #375 and #360
Contributor (creator of pull-request) checklist
📚 Documentation preview 📚: https://metatrain--379.org.readthedocs.build/en/379/