Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Alchemical Model from
torch_alchemical
repo #66Implement the Alchemical Model from
torch_alchemical
repo #66Changes from 16 commits
53ac431
3b82869
be6afa3
e4004c1
2911f9b
67939d4
2bdb5cb
f4a1d6d
b492cfe
ec73b36
4734372
62c97de
68e205c
e14526e
a6e8ed5
1d759bf
caa66f4
96dcd25
739b11e
8ca75d9
920db42
1834089
54866d6
8413adc
4f407f7
99a2cca
4e9e995
8ae033b
0b18f08
27c7065
4312b8a
5843cf8
ea481c1
3dc28ca
af079cd
8c0ba1e
2ebf2bc
cc304f5
a35e064
1d03698
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want this for each model in the docs, right @PicoCentauri? However, maybe we can leave the example here and run it from the test CI of the alchemical model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I would not duplicate this file. If we want this to be a test, let's make it a test and not an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, then I'll delete this file