Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add script runner to reset email translations #1072

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

YazeedLoonat
Copy link
Collaborator

This PR addresses #1056

  • Addresses only certain aspects of the issue

Description

This creates a new script runner endpoint to reset all the non-english translations

How Can This Be Tested/Reviewed?

This is going to take some time to double check but: run the new script runner locally. Double check that each of the strings: https://docs.google.com/spreadsheets/d/1aFoUc76C44SInzrac02cvG7UhxfLVyHoGwds6fmzqNA/edit?gid=481259231#gid=481259231 are in place and replacing the correct english string

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@YazeedLoonat
Copy link
Collaborator Author

Hey @ludtkemorgan I got too excited about that arg and didn't think to double check it would work in the null case. Updated per your recs! lemme know what you think

@YazeedLoonat YazeedLoonat force-pushed the 1056/reset-email-translations branch from 4678ea5 to c41d721 Compare February 3, 2025 16:41
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far just one missed translation string that I can see.

As discussed offline, the script should be updated to first delete the translation in the DB for the bay area jurisdiction. This entry causes issues because it is taking precedence over the non-jurisdiction non-english languages

api/src/services/script-runner.service.ts Outdated Show resolved Hide resolved
@YazeedLoonat
Copy link
Collaborator Author

Hey @ludtkemorgan this is ready for your 👀 again!

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good!
One thing for future testing that would be useful is if you could delete the jurisdiction specific translation in the seed staging. But the script looks great!

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Feb 5, 2025
@YazeedLoonat YazeedLoonat force-pushed the 1056/reset-email-translations branch from ab77e1b to 9dbb880 Compare February 5, 2025 18:22
@YazeedLoonat YazeedLoonat merged commit 710861f into main Feb 5, 2025
16 checks passed
@YazeedLoonat YazeedLoonat deleted the 1056/reset-email-translations branch February 5, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants