-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add script runner to reset email translations #1072
Conversation
Hey @ludtkemorgan I got too excited about that arg and didn't think to double check it would work in the null case. Updated per your recs! lemme know what you think |
4678ea5
to
c41d721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far just one missed translation string that I can see.
As discussed offline, the script should be updated to first delete the translation in the DB for the bay area jurisdiction. This entry causes issues because it is taking precedence over the non-jurisdiction non-english languages
Hey @ludtkemorgan this is ready for your 👀 again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good!
One thing for future testing that would be useful is if you could delete the jurisdiction specific translation in the seed staging. But the script looks great!
ab77e1b
to
9dbb880
Compare
This PR addresses #1056
Description
This creates a new script runner endpoint to reset all the non-english translations
How Can This Be Tested/Reviewed?
This is going to take some time to double check but: run the new script runner locally. Double check that each of the strings: https://docs.google.com/spreadsheets/d/1aFoUc76C44SInzrac02cvG7UhxfLVyHoGwds6fmzqNA/edit?gid=481259231#gid=481259231 are in place and replacing the correct english string
Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: