Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change the from email for gov delivery sends #1079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ludtkemorgan
Copy link
Collaborator

This PR addresses #1063

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Doorway would like the from email address in the "New Rental Opportunity" emails to be from a doorway specific email address. This was created by the govDelivery team, but by default automated sends (like from Bloom) take the organization's default email. This is to change the "from email" to this new email.

Notes:

  • The email was just created in the production instance of govDelivery and if you pass an invalid ID in the request, the "sendNow" request fails with a 422 error. This is why the code only adds this new value if it's not "stage" environment.

How Can This Be Tested/Reviewed?

Unfortunately there is no way to test this in a pre-production environment since that email doesn't exist anywhere else.

Here is what I did to test this code locally:

  • Made sure that it still works with the stage environment (email sends with the default "from email")
  • hardcode the ID locally to one that exists in the stage environment and test that I recieved the email with the expected different "from" email. Below is a screenshot for proof
image

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant