Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translation fixes #419

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix: translation fixes #419

merged 2 commits into from
Nov 21, 2023

Conversation

YazeedLoonat
Copy link
Collaborator

Issue Overview

This PR addresses issues #412 and #411

  • This change addresses the issue in full

Description

The spreadsheet: https://docs.google.com/spreadsheets/d/1M1Jzp9JIAi6h4gIg7KgCRvc8knJ8DJpIc1ii7et2crA/edit#gid=0 has a grip of translations/copy updates to be made. This goes through and makes those updates throughout

How Can This Be Tested/Reviewed?

It will require a bit of bouncing around but the spreadsheet should point you to where the copy update was made and that copy update should be made

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ludtkemorgan
Copy link
Collaborator

@YazeedLoonat BTW, the failing tests are flaky because of a cypress issue. I've address it in this PR: 28d42bf. But feel free to pull those changes over in order to get this PR merged

@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Nov 21, 2023
@YazeedLoonat YazeedLoonat merged commit e27c74a into main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants