Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: export lottery with sorted preferences by ordinal #976

Merged
merged 1 commit into from
Jan 2, 2025
Merged

release: export lottery with sorted preferences by ordinal #976

merged 1 commit into from
Jan 2, 2025

Conversation

jaredcwhite
Copy link
Collaborator

@ludtkemorgan ludtkemorgan force-pushed the release/lottery-preferences-sorted-ordinal branch from dc2d273 to d00a43f Compare January 2, 2025 17:54
@jaredcwhite @ludtkemorgan
fix: export lottery with sorted preferences by ordinal (bloom-housing…
d00a43f 
…#4464)

* fix: export lottery with sorted preferences by ordinal

* feat: ensure the preferences ordinals are coming from the particular listing

* test: add a unit test for listing preferences sorted by ordinal

* chore: add comments above method definition

(cherry picked from commit e415120)
@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Jan 2, 2025
@jaredcwhite jaredcwhite merged commit 303a190 into main Jan 2, 2025
16 checks passed
@jaredcwhite jaredcwhite deleted the release/lottery-preferences-sorted-ordinal branch January 2, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludtkemorgan ludtkemorgan ludtkemorgan approved these changes

Assignees
No one assigned
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredcwhite @ludtkemorgan