This repository was archived by the owner on Nov 24, 2020. It is now read-only.
Add create_thin classmethod to Partition #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a create_thin classmethod that will allow creating partitions with specified file sizes and paths, but without allocating any disk space.
Wolf480pl
commented
Aug 23, 2017
| dir_path = os.path.dirname(path) | ||
| os.makedirs(dir_path, exist_ok=True) | ||
|
|
||
| # Create empty file |
There was a problem hiding this comment.
The comment should say "Create the file if not existing" or something
| return cls(paths, chunk_size=chunk_size) | ||
|
|
||
| @classmethod | ||
| def create_thin(cls, paths, sizes, chunk_size=DEFAULT_CHUNK_SIZE): |
There was a problem hiding this comment.
Maybe sparse instead of thin? thin is not obvious (at least to me).
| os.makedirs(dir_path, exist_ok=True) | ||
|
|
||
| # Create empty file | ||
| open(path, 'a+b').close() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
create_thinclassmethod that will allow creating partitions with specified file sizes and paths, but without allocating any disk space.Also turn the
allocatestaticmethod into a classmethod for consistency.