Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import paths to fix 'no buildable Go source files error' re: logxi #70

Open
wants to merge 2 commits into
base: v1
Choose a base branch
from

Conversation

kenkouot
Copy link

@kenkouot kenkouot commented May 11, 2017

Fixes #66
Currently, the project is unusable with current glide.lock. The root cause is that the current glide.lock represents a dependency graph that is not compatible with v1 changes introduced here: f2918ee#diff-33921aca24f9053a9a0b9e289014da32R3

l have:

  • updated the logxi imports in dat.v1 to include the v1 package
  • downgraded the jo dependency back to the version with a v1 package, as dat imports still rely on that package.

@kenkouot
Copy link
Author

I've updated tests and running them manually produces no build errors. Continuous integration would be a helpful addition here, maybe TravisCI?

@kenkouot
Copy link
Author

@mgutz ping

@Janulka
Copy link

Janulka commented Jun 1, 2017

I am having the same issue while running automated build on CircleCI. @mgutz can you merge this PR please?

Janulka added a commit to Janulka/dat that referenced this pull request Jun 1, 2017
@f10et
Copy link

f10et commented Aug 11, 2017

@mgutz any update on this ? I am having the same issue

@thomasf
Copy link

thomasf commented Aug 15, 2017

this should most definitely be fixed

@im-kulikov
Copy link

Is there any progress?

@richp10
Copy link

richp10 commented Jan 18, 2018

Project seems to be unusable without this.. and the issue is outstanding for 9 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants