-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paged-remote-array.js #143
base: master
Are you sure you want to change the base?
Conversation
need to return the promises from the paged-remote-array init, otherwise `findPaged` will not return a promise, which is required in a `model` hook for Ember's 'wait until promises are resolved' functionality.
👍 |
I moved the |
Yes! I would like to have that! 👍 |
any chance these changes can get merged? |
Returning the result of "get" on the promise here I don't think will have any effect. I mean, it does, but I'm thinking this isn't the best place to set up the promise chain. I just submitted a different PR that returns the promise chain where it is overridding the proxy: https://github.com/mharris717/ember-cli-pagination/pull/173/files#diff-7bfb08d900d77900cce45eec3f9758b3R12. Thoughts? |
@noslouch We had to make some breaking changes to fix the Ember Bindings deprecation. If you change this PR for the current version I will merge it. |
need to return the promises from the paged-remote-array init, otherwise
findPaged
will not return a promise, which is required in amodel
hook for Ember's 'wait until promises are resolved' functionality.