Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.0 and 3.1 to CI, Split out Faraday 1 and 2 #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petergoldstein
Copy link

@petergoldstein petergoldstein commented Mar 13, 2022

This PR adds Ruby 3.0 and 3.1 to the CI matrix and adds a new row for Faraday major version (given the recent release of Faraday 2 and the middleware specific changes)

To support this goal this PR also:

  1. Addresses a few lints raised by Rubocop
  2. Moves a number of development dependencies from the Gemfile to the gemspec
  3. Adds dedicated Faraday 1 and Faraday 2 gemfiles
  4. Sets a minimum Ruby version of 2.5
  5. Fixes an ActiveSupport loading issue for recent versions of ActiveSupport

Everything runs green on my fork.

@codeclimate
Copy link

codeclimate bot commented Mar 13, 2022

Code Climate has analyzed commit b78e7ad and detected 0 issues on this pull request.

View more on Code Climate.

@nanego
Copy link

nanego commented Apr 8, 2022

Thank you for this Pull Request. The current version of the gem seems to be incompatible with Faraday 2.
I had to add this line to my Gemfile to prevent any update to Faraday 2:
gem 'faraday', '~> 1.0'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants