Create lambda handlers #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhorod
reviewed
Jan 20, 2025
|
|
||
| class FunctionHandlerImpl( | ||
| private val function: FunctionDefinition, | ||
| private val analyzedFunction: AnalyzedFunction, | ||
| // List of parents' handlers ordered from immediate parent. | ||
| private val ancestorFunctionHandlers: List<FunctionHandler>, | ||
| private val ancestorFunctionHandlers: List<CallableHandler>, // first (or last?) can be Lambda, not Function |
There was a problem hiding this comment.
I mean, I don't really understand what's this comment for 😄
Does it mean that we have to be careful what we provide in the constructor? Or how we use these handlers? Or is it just explaning why it's CallableHandler and not FunctionHandler.
If it's the last one then I think we don't have to explain it, it feels natural that the interface is as general as it can be.
SebastianSpyrzewski
changed the title
SebastianSpyrzewski
force-pushed
the
gen-variable-access-for-closures
branch
from
2edc951 to
d411576
Compare
SebastianSpyrzewski
force-pushed
the
gen-variable-access-for-closures
branch
from
302b980 to
b92ddbe
Compare
mhorod
reviewed
Jan 20, 2025
| import kotlin.math.max | ||
|
|
||
| abstract class CallableHandlerImpl( | ||
| private val analyzedFunction: AnalyzedFunction, // TODO: we need to change it so it also covers lambda expressions |
There was a problem hiding this comment.
You can also describe the TODOs here so it's all in one place: #305
mhorod
reviewed
Jan 20, 2025
| @@ -22,7 +24,8 @@ class PrologueEpilogueHandler( | |||
| fun generatePrologue(): List<CFGNode> { | |||
| val nodes = mutableListOf<CFGNode>() | |||
| nodes.add(registerUse(rsp) subeq integer(REGISTER_SIZE)) | |||
| nodes.add(pushLabel(getStackFrameLocation(handler.getFunctionDeclaration()))) | |||
| // TODO: how to cover lambdas here? | |||
There was a problem hiding this comment.
This also seems like something to think about together, no? #305
mhorod
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created lambda handler and made it access correctly variables from closure.
Some TODO's in PrologueEpilogueHandler and FunctionAnalysis that I believe need to be done next week.