Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature: scan dirs #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmikalkenas
Copy link

Issue: #5

Using symfony finder component I have managed to implement ability to define directories in config files in which yml/yaml files would be found for checking.

Remaining question:
currently all files inherit options defined by directory. Maybe it would be useful to exclude files from scanning if they are defined in config file? For example: if config file contains app/config: and next line app/config/services.yml, then I think we should exclude services.yml file from scanned files in app/config directory and use options defined under that concrete file.

@rmikalkenas
Copy link
Author

@mhujer ping :)

@mhujer
Copy link
Owner

mhujer commented Sep 13, 2020

@rmikalkenas Hi! Thanks for the PR, but I'm sorry, I'm not using this tool anymore, so I can't review this. (The reason is that the Symfony configs are now split into many small files where sorting is less useful - I keep them sorted logically instead),

But AFAIK @OndraM has been using yaml sort checker, so maybe he will find some time to review this.

@sspooky13
Copy link

@rmikalkenas Hello, maybe I will behave as asshole but I have library for yaml standards too and that library knows to find all .yaml/.yml/.yml.dist/.yaml.dist in directory but it's true it doesn't know to exclude keys from alphabetical check (yet). So, if you are interested you can check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants