updated testData and compiled the code for simple-image support

miadabdi · Dec 24, 2020 · ae64009 · ae64009
1 parent dd5b598
commit ae64009
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 3 deletions.
diff --git a/build/Parser.browser.js b/build/Parser.browser.js
@@ -81,7 +81,12 @@ var edjsParser = function () {
       var imgClass = config.image.imgClass || "";
       var imageSrc;
 
-      if (config.image.path === "absolute") {
+      if (data.url) {
+        // simple-image was used and the image probably is not uploaded to this server
+        // therefore, we use the absolute path provided in data.url
+        // so, config.image.path property is useless in this case!
+        imageSrc = data.url;
+      } else if (config.image.path === "absolute") {
         imageSrc = data.file.url;
       } else {
         imageSrc = config.image.path.replace(/<(.+)>/, function (match, p1) {

diff --git a/build/Parser.esm.js b/build/Parser.esm.js
@@ -78,7 +78,12 @@ var defaultParsers = {
     var imgClass = config.image.imgClass || "";
     var imageSrc;
 
-    if (config.image.path === "absolute") {
+    if (data.url) {
+      // simple-image was used and the image probably is not uploaded to this server
+      // therefore, we use the absolute path provided in data.url
+      // so, config.image.path property is useless in this case!
+      imageSrc = data.url;
+    } else if (config.image.path === "absolute") {
       imageSrc = data.file.url;
     } else {
       imageSrc = config.image.path.replace(/<(.+)>/, function (match, p1) {

diff --git a/build/Parser.node.js b/build/Parser.node.js
@@ -85,7 +85,13 @@ var defaultParsers = {
     } ${data.withBackground ? "img-bg" : ""}`;
     const imgClass = config.image.imgClass || "";
     let imageSrc;
-    if (config.image.path === "absolute") {
+
+    if (data.url) {
+      // simple-image was used and the image probably is not uploaded to this server
+      // therefore, we use the absolute path provided in data.url
+      // so, config.image.path property is useless in this case!
+      imageSrc = data.url;
+    } else if (config.image.path === "absolute") {
       imageSrc = data.file.url;
     } else {
       imageSrc = config.image.path.replace(

diff --git a/test/testData.json b/test/testData.json
@@ -1,6 +1,16 @@
 {
     "time": 1601898039654,
     "blocks": [{
+            "type": "image",
+            "data": {
+                "url": "https://www.tesla.com/tesla_theme/assets/img/_vehicle_redesign/roadster_and_semi/roadster/hero.jpg",
+                "caption": "Roadster // tesla.com",
+                "withBorder": false,
+                "withBackground": false,
+                "stretched": true
+            }
+        },
+        {
             "type": "paragraph",
             "data": {
                 "text": "Hello There, it is a test post related to <a href=\"https://google.com\">Google</a> which is the <b>biggest</b> search engine!"