fix _connect hang when not registered device #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this project! I found this when trying to implement control over my ventilation via Google Home and this is very helpful.
While running
aiocomfoconnect register
it hangs on my machine.I think this is bug introduced while implementing reconnect logic.
When exception ComfoConnectNotAllowed is thrown, it will be dropped and
await connected
will hang until time out.And then code
will not be executed, so app will never register.
After this fix I can register and use this module properly.