Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with zipOrAccumulate with two procedures. #112

Closed
wants to merge 1 commit into from
Closed

Fix an issue with zipOrAccumulate with two procedures. #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kotlin-result/src/commonMain/kotlin/com/github/michaelbull/result/Zip.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ public inline fun <T1, T2, E, V> zipOrAccumulate(
val result2 = producer2()

val results = listOf(
producer1(),
producer2(),
result1,
result2,
)

return if (results.allOk()) {
Expand Down
46 changes: 46 additions & 0 deletions kotlin-result/src/commonTest/kotlin/com/github/michaelbull/result/ZipTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,52 @@ class ZipTest {

class ZipOrAccumulate {

@Test
fun returnsTransformedValueIfAllOfTwoOk() {
val result = zipOrAccumulate(
{ Ok(10) },
{ Ok(20) },
Int::plus,
)

assertEquals(
expected = Ok(30),
actual = result,
)
}

@Test
fun returnsOneErrIfOneOfTwoErr() {
val result = zipOrAccumulate(
{ Ok(10) },
{ produce(20, "hello") },
Int::plus,
)

val expectedErrors = listOf("hello")

assertEquals(
expected = Err(expectedErrors),
actual = result,
)
}

@Test
fun returnsErrsIfAllOfTwoErr() {
val result = zipOrAccumulate(
{ produce(10, "foo") },
{ produce(20, "bar") },
Int::plus,
)

val expectedErrors = listOf("foo", "bar")

assertEquals(
expected = Err(expectedErrors),
actual = result,
)
}

@Test
fun returnsTransformedValueIfAllOk() {
val result = zipOrAccumulate(
Expand Down