Add Compute Budget Instructions #403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MHHukiewitz Thanks for the PR. These instructions already exist in Solders, would you mind wrapping the Solders instructions instead of using construct-py? https://kevinheavey.github.io/solders/api_reference/compute_budget.html |
|
It's worth considering whether there's anything that should be added at all here vs just using what's in Solders |
|
Oh Christ, I didn't notice. Yeah, I think this PR is superfluous then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GM!
Due to the dire need for priority fees to have any chance at landing transactions, I decided to implement the Compute Budget program's instructions for solder.
I added them under the
splmodule, even though that is not technically correct, but I assume that is where people would be looking for those instructions.For some reason regarding docker, I couldn't run the integration tests directly on my machne. Maybe the CI/CD of this repo can catch the errors I might have made.
I based this implementation and its layouts on the Typescript implementation of solana-labs/solana-web3.js.
Suggestions welcome!