MDL-76665: Prevent duplication and restoration of disabled SEB template.

michaelkotlyar · Jul 8, 2024 · e0ccb84 · e0ccb84
1 parent 7d7a871
commit e0ccb84
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/mod/quiz/accessrule/seb/backup/moodle2/restore_quizaccess_seb_subplugin.class.php b/mod/quiz/accessrule/seb/backup/moodle2/restore_quizaccess_seb_subplugin.class.php
@@ -24,7 +24,7 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-use quizaccess_seb\seb_quiz_settings;
+use quizaccess_seb\{seb_quiz_settings, settings_provider, template};
 
 defined('MOODLE_INTERNAL') || die();
 
@@ -73,7 +73,14 @@ public function process_quizaccess_seb_quizsettings($data) {
         unset($data->id);
         $data->timecreated = $data->timemodified = time();
         $data->usermodified = $USER->id;
-        $DB->insert_record(quizaccess_seb\seb_quiz_settings::TABLE, $data);
+
+        // Do not use template if it is no longer enabled.
+        if (!$DB->record_exists(template::TABLE, ['id' => $data->templateid, 'enabled' => '1'])) {
+            $data->templateid = 0;
+            $data->requiresafeexambrowser = settings_provider::USE_SEB_NO;
+        }
+
+        $DB->insert_record(seb_quiz_settings::TABLE, $data);
 
         // Process attached files.
         $this->add_related_files('quizaccess_seb', 'filemanager_sebconfigfile', null);
@@ -112,7 +119,10 @@ public function process_quizaccess_seb_template($data) {
         }
 
         // Update the restored quiz settings to use restored template.
-        $DB->set_field(\quizaccess_seb\seb_quiz_settings::TABLE, 'templateid', $template->get('id'), ['quizid' => $quizid]);
+        // Check if template is enabled before using it.
+        if ($template->get('enabled')) {
+            $DB->set_field(seb_quiz_settings::TABLE, 'templateid', $template->get('id'), ['quizid' => $quizid]);
+        }
     }
 
 }

diff --git a/mod/quiz/accessrule/seb/classes/settings_provider.php b/mod/quiz/accessrule/seb/classes/settings_provider.php
@@ -585,8 +585,22 @@ public static function get_requiresafeexambrowser_options(\context $context): ar
      * @return array
      */
     protected static function get_template_options(): array {
+        global $DB, $PAGE;
         $templates = [];
-        $records = template::get_records(['enabled' => 1], 'name');
+        $templatest = template::TABLE;
+        $sebquizsettingst = seb_quiz_settings::TABLE;
+        $cmid = $PAGE->cm->id ?? -1;
+
+        $sql = "SELECT *
+                FROM {{$templatest}} t
+                WHERE enabled = 1
+                OR EXISTS (
+                    SELECT 1
+                    FROM {{$sebquizsettingst}}
+                    WHERE templateid = t.id
+                    AND cmid = ?
+                )";
+        $records = $DB->get_records_sql($sql, [$cmid]);
         if ($records) {
             foreach ($records as $record) {
                 $templates[$record->get('id')] = $record->get('name');