Fixed PubSubMessage having to contain UTF-8 String as payload #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thank you for this PR and sorry for my late response. I will take a look at this tomorrow, over the holidays my time was limited to work on stuff so now I have to work on the backlog. |
michaelvanstraten
requested changes
Dec 31, 2023
Comment on lines
-163
to
-168
| case "message", "pmessage", "smessage": | ||
| let payload = try String(array.popLast()) | ||
|
|
||
| if let actual_payload = array.popLast() { | ||
| channel = payload | ||
| type = try .message(pattern: channel, payload: String(actual_payload)) |
There was a problem hiding this comment.
I was kind of trying to make this as covering as possible, so "message", "pmessage", "smessage" all in one case, but I could admit that this is somewhat hard to read/understand.
michaelvanstraten
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #9 , current implementation of PubSubMessage can only support UTF8 String.
This PR enables PubSubMessage to support binary data.
Additionally, the
patternandchannelfields inPubSubMessagemight also contain binary data. However, in most usage scenarios, this is unlikely to be the case, which is why I haven't modified them alongside the payload. Nonetheless, there's still a possibility that binary data might be used in these fields, and we might need to consider our implementation approach regarding this?Also, I adjusted a line of code that seemed incorrect: pattern should not be the same as channel.
swifty-redis/Sources/SwiftyRedis/PubSub.swift
Line 168 in f4cdb34