Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/lecturer listeners #371

Merged
merged 6 commits into from
Jun 9, 2021
Merged

Refactor/lecturer listeners #371

merged 6 commits into from
Jun 9, 2021

Conversation

rozchlastywacz
Copy link
Collaborator

@rozchlastywacz rozchlastywacz commented Jun 9, 2021 •
edited by Derstilon
Loading

fix socket emit listening to be global

@rozchlastywacz rozchlastywacz self-assigned this Jun 9, 2021
@rozchlastywacz rozchlastywacz changed the base branch from master to develop June 9, 2021 02:48
@rozchlastywacz rozchlastywacz requested a review from michal367 June 9, 2021 02:48
@rozchlastywacz rozchlastywacz added bug Something isn't working front Related to front-end lecturerapp labels Jun 9, 2021
@rozchlastywacz rozchlastywacz added this to the M3 milestone Jun 9, 2021
This was linked to issues Jun 9, 2021
Reakcie od od studentów nie są odbierane jeśli jest się poza kartą sesji #349
Closed
Wiadomości od studentów nie są odbierane jeśli jest się poza kartą sesji #348
Closed
@rozchlastywacz rozchlastywacz requested a review from Derstilon June 9, 2021 02:49
@Derstilon Derstilon linked an issue Jun 9, 2021 that may be closed by this pull request
Poprawa odbierania listy studentów #350
Open
Derstilon
Derstilon requested changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@Derstilon Derstilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I've added student, question and quiz and then I tried to go back to session dashboard but it wasn't there

@ostatni5 ostatni5 force-pushed the refactor/lecturer-listeners branch from 1b26306 to d9c8d05 Compare June 9, 2021 07:10
@michal367 michal367 removed a link to an issue Jun 9, 2021
Poprawa odbierania listy studentów #350
Open
@Derstilon Derstilon self-requested a review June 9, 2021 07:27
@rozchlastywacz rozchlastywacz merged commit 3b165d2 into develop Jun 9, 2021
rozchlastywacz added a commit that referenced this pull request Jun 9, 2021
@rozchlastywacz
Revert "Refactor/lecturer listeners (#371)"
41e2a29 
This reverts commit 3b165d2.
@rozchlastywacz rozchlastywacz mentioned this pull request Jun 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michal367 michal367 michal367 approved these changes

@Derstilon Derstilon Derstilon approved these changes

Assignees

@rozchlastywacz rozchlastywacz

Labels
bug Something isn't working front Related to front-end lecturerapp
Projects
None yet
Milestone
M3
4 participants
@rozchlastywacz @michal367 @Derstilon @ostatni5