metadata: Add support for gnome-shell 43

[emansom]

Works without a hitch (functionality wise, afaict) in GNOME 43.alpha.

Using FCGU repo and AUR package gnome-shell-extension-dash-to-dock43 to test.

There's a JS error reported in the logs, however, this doesn't seem to hinder functionality.

jul 14 17:58:19 x11sslf gnome-shell[256233]: JS ERROR: Exception in callback for signal: open-state-changed: TypeError: this.setForcedHighlight is not a function
                                             _onMenuPoppedDown@resource:///org/gnome/shell/ui/appDisplay.js:3209:14
                                             _onMenuPoppedDown@/usr/share/gnome-shell/extensions/[email protected]/appIcons.js:1292:56
                                             popupMenu/<@/usr/share/gnome-shell/extensions/[email protected]/appIcons.js:1311:26
                                             _emit@resource:///org/gnome/gjs/modules/core/_signals.js:114:47
                                             close@resource:///org/gnome/shell/ui/popupMenu.js:941:14
                                             itemActivated@resource:///org/gnome/shell/ui/popupMenu.js:603:28
                                             _connectItemSignals/<@resource:///org/gnome/shell/ui/popupMenu.js:640:22
                                             activate@resource:///org/gnome/shell/ui/popupMenu.js:197:14
                                             vfunc_button_release_event@resource:///org/gnome/shell/ui/popupMenu.js:141:14

[vanvugt]

It looks like setForcedHighlight was introduced in gnome-shell 41.3.1 so that JS ERROR shouldn't happen in current versions... What version of gnome-shell was the error from?

[emansom]

It looks like setForcedHighlight was introduced in gnome-shell 41.3.1 so that JS ERROR shouldn't happen in current versions... What version of gnome-shell was the error from?

43.alpha as noted above.

Just checked the logs again using journalctl -b /usr/bin/gnome-shell and searching for dash-to-dock: the error is no longer there. Not sure what caused it previously, it may have been unrelated to this extension altogether.

[LoneFenris]

That error sounds like what #1759 addresses.

[jbicha]

I'm not a maintainer here, but could you please update your merge request to use "43" instead of the alpha? GNOME 43 is now at API Freeze so hopefully things would continue working for the 43 series from now on.

[jbicha]

We could probably close this and just cherry-pick c50390d9236 to the master branch.

[vanvugt]

We could probably close this and just cherry-pick c50390d9236 to the master branch.

I don't have push privileges for master so it needs to be a pull request.

[vanvugt]

@emansom, please change 43.alpha to 43

[emansom]

@vanvugt Done 👍🏻

[vanvugt]

Approved, thanks.