Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve dock opacity when draging window preview in shell overview #1804

Open
wants to merge 1 commit into
base: ubuntu-dock
Choose a base branch
from

Conversation

yellowgh0st
Copy link

@yellowgh0st yellowgh0st commented Aug 28, 2022

In order to maintain visual rhythm, symmetry and consistency I suggest this change that preserves dock opacity during the window preview drag user event.

With this change, the workspace body that allows user to drop the window on to workspace or go to desired workspace by click, gets on both left and right sides visually equal width. I say visually because technically the workspace bodies still differ
because the part of the left one is being hidden under the dock.

During the drag event dock doesn't provide any functionality and it actually prevents dropping the window which can be confusing when is transparent.

By leaving the dock's opacity same as is top bar's we achieve even more consistency.

@3v1n0
Copy link
Collaborator

3v1n0 commented Sep 21, 2022

Mh, personally I think it makes sense to make it opaque in case it was not to make clear that such operation has not to be performed on dock.

You can make it an option, but in general this should happen IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants