Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the drag placeholder smaller than other icons #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackstanek
Copy link

This matches the native shell more closely, and also reduces the
chances that the drag placeholder will look blurry or pixelated. I'm
not sure if there's a better factor to divide by, in order to more closely
match the native shell, but it seemed to look fine to me.

This matches the native shell more closely, and also reduces the
chances that the drag placeholder will look blurry or pixelated.
@micheleg
Copy link
Owner

Hi Jack,

thanks for your contribution. I'm not sure I understand what you mean by matching the native shell. That part of code comes straight away from upstream

https://git.gnome.org/browse/gnome-shell/tree/js/ui/dash.js#n912

therefore I would expect it to produce the same results. Could you explain further (maybe a screenshot)?

@jackstanek
Copy link
Author

Hi,
After some further inspection, it seems that the problem actually stems from the Gnome Shell theme I was using, where natively the drag placeholder looked fine, but in the dock, it looked way larger than it should have: you can see the dock versus the native dash... I suspected it had to do with the icon sizing code, but perhaps it has to do with the icon selection (that is, the dock is choosing the wrong size of the drag placeholder icon?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants