Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min font to 6 in font range input #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bondden
Copy link

@bondden bondden commented Feb 9, 2016

On large screens it allows to display more content.

@nainoa
Copy link

nainoa commented Feb 10, 2016

@bondden
giphy

@micjamking
Copy link
Owner

😂 😂 😂

@bondden
Copy link
Author

bondden commented Feb 11, 2016

@nainoa, @micjamking, ok, ok :) But I still install the great devtools-author from local packge on all supported browsers with 8px font :)

@micjamking
Copy link
Owner

@bondden forking a public repo to make a small personal modification is not only perfectly acceptable, but in fact, encouraged. I'm going to leave this PR up on the chance someone else may have this suggestion (and quite frankly, because I think this is hilarious 😆).

All hilarity aside, I don't believe this is an enhancement/improvement a majority of users would benefit from. Most people I have talked to complain the default DevTools font-size of 11px is too small, so chopping that in half seems a little absurd (see below).

Ex: 6px font-size (Thunderbolt Display)
screen shot 2016-02-09 at 2 35 08 pm

...but, because I like the cut of your jib, I'm going to leave this PR up for discussion.

@catmeme
Copy link

catmeme commented Apr 28, 2016

Lowering the minimum font-size in the range slider does not remove or hinder any existing functionality.

That being said, I have a use case for a smaller font. I primarily operate on a 2560x1440 27" monitor at work via a docked laptop. The fonts are very legible for me at 10px on this resolution.

However, when I dock at home, I'm on a 27" monitor that's only 1080p. The fonts are very large for me there and having the ability to lower it would be very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants