feat: pgl_backend_s3: add option for no_verify_ssl #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The frontend part of the code you made a change to is currently being rewritten from scratch as we're moving away from React to Vanilla JS. What that means is we can't allow code changes in the frontend side as what you had to change is gonna disappear in the next few months. I will keep this PR open as we should be able to merge this minus the frontend change to enable that same functionality once the entire migration is done. |
|
oh snap |
mickael-kerjean
force-pushed
the
master
branch
19 times, most recently
from
6ad50b8
to
8ba16f7
Compare
mickael-kerjean
force-pushed
the
master
branch
2 times, most recently
from
f077123
to
0ff9d62
Compare
mickael-kerjean
force-pushed
the
master
branch
from
53b12f9
to
96b566e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a User I want to be able to ignore SSL Verification (in case the authority is unknown f.e.) so that I can still connect without getting x509 certificate errors.
This PR adds a checkbox where the user can check this option:
This PR also adds the option to use boolean checkboxes with labels via the Formbuilder.
I did not add any translations as the other fields didn't have any as well. I also am missing a contribution Guide