Add build args: GIT_REPO GIT_REF #752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-kerjean
force-pushed
the
master
branch
from
53b12f9
to
96b566e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think its a good idea to allow building the Docker image from an arbitrary repository and git ref id, otherwise it will always build from your repo at master, which may not be what someone wants. I have set the default ARGS the same as they were before, so this should be identical to the build before if you omit the args.
By the way, my prompt for doing this was that I noticed the latest-arm64 image is much older than the latest (amd64) tag, because I wanted to run the latest version on Raspberry Pi.