Fixed maxiEnv::adsr #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sustain was set to 0, maxiEnv::adsr would not function properly. With the new changes, it is now simple to create pluck sounds by setting the sustain to 0, and then adjusting decay and release. When the trigger is released, the envelope will automatically move to the next phase, allowing for rapid playing of plucked notes as well
This reverts commit 51de07a.
When sustain was set to 0, maxiEnv::adsr would not function properly. With the new changes, it is now simple to create pluck sounds by setting the sustain to 0, and then adjusting decay and release. When the trigger is released, the envelope will automatically move to the next phase, allowing for rapid playing of plucked notes as well
|
I had the same issue with If you want I can open a new pull request with just the needed change? |
|
Yeah, go ahead and make a new PR. I think whoever owns the repo might not be active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sustain was set to 0, maxiEnv::adsr would not function properly. With the new changes, it is now simple to create pluck sounds by setting the sustain to 0, and then adjusting decay and release. When the trigger is released, the envelope will automatically move to the next phase, allowing for rapid playing of plucked notes as well