Fix registry cache broken (#2715)

* services is shared between routines, when application change services returned by get function may lead to other routine set a changed services to cache * services is shared between routines, when application change services returned by get function may lead to other routine set a changed services to cache --------- Co-authored-by: Shuaihu Liu <[email protected]>
micro · Jul 2, 2024 · 4d5b3b0 · 4d5b3b0
1 parent e9ceb66
commit 4d5b3b0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/registry/cache/cache.go b/registry/cache/cache.go
@@ -161,11 +161,12 @@ func (c *cache) get(service string) ([]*registry.Service, error) {
 		}
 
 		// cache results
+		cp := util.Copy(services)
 		c.Lock()
-		c.set(service, util.Copy(services))
+		c.set(service, services)
 		c.Unlock()
 
-		return services, nil
+		return cp, nil
 	}
 
 	// watch service if not watched