invalidate service if node was not updated #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are ttls per service but not node. I have a feeling it comes down to. There's a lot of edge cases to deal with and caching can be quite hard to do properly. So the idea is that you don't want to just throw away a node in case there's some sort of upstream issue with the registry. I'm not really maintaining this anymore so I will accept your PR if you think it works |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
cache-verify-node-ttl
branch
from
7062d5b
to
cdb6a0d
Compare
kobergj
approved these changes
Oct 28, 2024
asim
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nats does not yet emit events when a key is evicted due to ttl. This might cause the cache to never receive an update for the node. This PR will invalidtate a service if any node has not been updated in time.
Let me know what you think and why node TTL was not taken into account, yet?