Fix gatsby-plugin-sitemap example #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`As of v4 the 'exclude' option was renamed to 'excludes'`, see https://www.gatsbyjs.com/plugins/gatsby-plugin-sitemap/?=sitemap#options
|
This would break for anyone still using Gatsby 2 or 3, correct? So this merge would need to be a major version update to this plugin, I think. @jimmyn What do you think? |
|
This wouldn't break anything since its documentation, personally i think its correct to always have the most up to date documentation, and if you really wanted, to call out that this is different from version 2/3 and that they should pay attention if thats the version they are using. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v4 the 'exclude' option was renamed to 'excludes', see https://www.gatsbyjs.com/plugins/gatsby-plugin-sitemap/?=sitemap#options