Abstract ManagedChannel Creation #195
Open
+175
−66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using this project, I found myself wanting to customize the
ManagedChannel
that was created. While I saw there was an option to overridebuildChannel
, I thought it might be nicer to provide that as a dependency toTiller
instead.As such, I created a
ManagedChannelFactory
interface which is used to create aManagedChannel
from aLocalPortForward
. I also provide the default implementation (DefaultManagedChannelFactory
) that migrates existing logic from the currentbuildChannel
method. It also allows the provision of aManagedChannelConfigurer
which is passed theManagedChannelBuilder
and is able to manipulate it before it is finally built.This allows users to do the following if they simply want to configure settings on the
ManagedChannel
instead of having to subclassTiller
.Let me know if I've not explained anything well, or if you have any concerns or changes you'd like.