Lost subject attributes #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
August 27, 2018 16:40
Plus added stdout/stderr logging
Format for logger.Log() params is pairs of name and attribute. Without this change, the program dies with no output. Verify by starting the server with an invalid argument to -csrverifierexec
For example, without this change an emailAddress (oid 1.2.840.113549.1.9) that is present in the CSR's subject will not be present in the subject of the signed and returned certificate.
|
Branched the fix from the wrong point, ignore/delete this PR, see PR#93 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugly workaround for #91
This allows non-standard subject elements such as "emailAddress" (sometimes aka "E") to be returned by the golang function pkix.Name.ToRDNSequence() by copying them from Names (which is not exhaustively checked by that function) to ExtraNames (which is).