Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Gradle Version Catalog and upgrade to use latest stable versions #247

Closed
wants to merge 15 commits into from

Conversation

donbeave
Copy link
Contributor

@donbeave donbeave commented Mar 16, 2022

This PR includes an update for several dependencies:

  1. Micronaut 3.3.4
  2. graphql-java 18.0
  3. graphql-java-tools 12.0.2

Synced project to the https://github.com/micronaut-projects/micronaut-project-template repository.

Migrated to Gradle Version Catalogs.

@donbeave
Copy link
Contributor Author

I have verified all examples are working correctly with these upgrades.

@sdelamo
Copy link
Contributor

sdelamo commented Mar 23, 2022

I have verified all examples are working correctly with these upgrades.

We are going to migrate the examples to guides. in case, If you are interested in contributing to that migration.

patrickdronk
patrickdronk previously approved these changes Apr 1, 2022
@donbeave
Copy link
Contributor Author

Can this PR be merged?

@donbeave
Copy link
Contributor Author

@sdelamo @alvarosanchez can we merge this first? I'm preparing another PR that will migrate this project to use Gradle Version Catalog.

@alvarosanchez
Copy link
Member

There is one failing job, though?

@donbeave donbeave changed the title Upgrade to use latest stable versions Migrate to Gradle Version Catalog and upgrade to use latest stable versions Apr 29, 2022
@donbeave
Copy link
Contributor Author

@alvarosanchez I have fixed the GraalVM build, but Sonaqube task still failing:

Execution failed for task ':sonarqube'.
[2489](https://github.com/micronaut-projects/micronaut-graphql/runs/6235080194?check_suite_focus=true#step:7:2489)
> Unable to load component class org.sonar.scanner.scan.filesystem.ProjectFileIndexer

I'm not very sure, but it can be the issue with the Sonarqube Groovy plugin: https://community.sonarsource.com/t/unable-to-load-component-class-org-sonar-scanner-scan-filesystem-projectfileindexer/41352

P.S. Also this PR added a migration to Gradle Version Catalog.

@alvarosanchez
Copy link
Member

Don't worry about the Sonarqube workflow. It's failing because GitHub won't expose the Sonar secret to workflows triggered from forked repos. Known limitation.

@donbeave
Copy link
Contributor Author

Can we merge this PR?

@donbeave
Copy link
Contributor Author

@alvarosanchez @sdelamo I'm really sorry for pushing... Can this PR be merged?

@timyates
Copy link
Contributor

timyates commented Aug 2, 2022

Thanks again @donbeave 😎 👍

Superseded by #280

I rolled back the version updates, as this would require a major release of this, and Micronaut 4.0.0

@timyates timyates closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants