Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micronaut OAuth2 OIDC Microsoft Identity Platform #1482

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Sep 11, 2024

./gradlew micronautOauth2OidcMicrosoftBuild

Secure a Micronaut application with Microsoft Identify Platform.pdf

./gradlew micronautOauth2OidcMicrosoftBuild
Copy link
Contributor

@graemerocher graemerocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I would probably add some explanation about "Disable issuer claim validation" and why it doesn't match and what the impact of disabling this is

@@ -116,6 +116,14 @@ common:runapp.adoc[]

image::microsoft-identity-platform/microsoftvideo.gif[]

== GraalVM Reflection Metadata

Thymleaf access via Reflection several classes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change to Thymleaf accesses several classes via reflection.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to use a native compatible engine like JTE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants