-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support generate extensions for openapi generator. #1796
base: 6.13.x
Are you sure you want to change the base?
Conversation
Please, merge 6.12.x into this PR |
bfc360a
to
84a764a
Compare
done |
@@ -21,6 +21,7 @@ PACKAGE + | |||
PROTECTED + | |||
PUBLIC | Default: `PUBLIC` | |||
|`*micronaut.openapi.json.format*` | Is this property true, output file format will be JSON, otherwise YAML. | Default: `false` | |||
|`*micronaut.openapi.generator.extensions.enabled*` | If this property is 'true', then generated OpenAPI specification will be with extensions for OpenAPI Generator and the generated client according to this specification will be much more accurate than without it. For example, enumerations will be described with extensions `x-enum-varnames`, `x-enum-descriptions` and `x-deprecated` | Default: `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we link to these extensions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here described only two of them: https://openapi-generator.tech/docs/templating/
x-enum-varnames
, x-enum-descriptions
x-deprecated
- only in PR: OpenAPITools/openapi-generator#19673
I think you need to understand that the open api generator is a half-dead project. They don't merge PRs for months (or even years). You shouldn't expect any standard from it, there hasn't been any active development in it for over a year.
I look at what extensions are supported in the spring generator and try to add new ones so that our generator can generate perfect code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My issue, is how are people going to discover how to use these non standard extensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rightly. I'll add documentation tomorrow
can you merge 6.13.x into this branch? |
b999b66
to
a025ad4
Compare
@sdelamo all conflict solved in all PR's. Could you merge all PR's, please? |
Improvements in normalization
a025ad4
to
dc93b3d
Compare
Improvements in normalization.