Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support generate extensions for openapi generator. #1796

Open
wants to merge 1 commit into
base: 6.13.x
Choose a base branch
from

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Sep 28, 2024

Improvements in normalization.

@sdelamo
Copy link
Contributor

sdelamo commented Sep 30, 2024

Please, merge 6.12.x into this PR

@altro3 altro3 force-pushed the generator-extensions branch 2 times, most recently from bfc360a to 84a764a Compare September 30, 2024 07:43
@altro3
Copy link
Collaborator Author

altro3 commented Sep 30, 2024

done

@@ -21,6 +21,7 @@ PACKAGE +
PROTECTED +
PUBLIC | Default: `PUBLIC`
|`*micronaut.openapi.json.format*` | Is this property true, output file format will be JSON, otherwise YAML. | Default: `false`
|`*micronaut.openapi.generator.extensions.enabled*` | If this property is 'true', then generated OpenAPI specification will be with extensions for OpenAPI Generator and the generated client according to this specification will be much more accurate than without it. For example, enumerations will be described with extensions `x-enum-varnames`, `x-enum-descriptions` and `x-deprecated` | Default: `false`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we link to these extensions ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here described only two of them: https://openapi-generator.tech/docs/templating/

x-enum-varnames, x-enum-descriptions

x-deprecated - only in PR: OpenAPITools/openapi-generator#19673

I think you need to understand that the open api generator is a half-dead project. They don't merge PRs for months (or even years). You shouldn't expect any standard from it, there hasn't been any active development in it for over a year.

I look at what extensions are supported in the spring generator and try to add new ones so that our generator can generate perfect code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My issue, is how are people going to discover how to use these non standard extensions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rightly. I'll add documentation tomorrow

@sdelamo sdelamo changed the base branch from 6.12.x to 6.13.x September 30, 2024 13:31
@sdelamo
Copy link
Contributor

sdelamo commented Sep 30, 2024

can you merge 6.13.x into this branch?

@altro3 altro3 force-pushed the generator-extensions branch 2 times, most recently from b999b66 to a025ad4 Compare September 30, 2024 13:53
@altro3
Copy link
Collaborator Author

altro3 commented Oct 2, 2024

@sdelamo all conflict solved in all PR's. Could you merge all PR's, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants