Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open ulp file in binary mode instead of text mode #100

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

pidou46
Copy link
Contributor

@pidou46 pidou46 commented Dec 14, 2024

Avoid rising "unicode exception" when running from mp1.24, see issue #99

Avoid rising "unicode exception" when running from mp1.24
Copy link
Collaborator

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing.

@wnienhaus
Copy link
Collaborator

Sorry for closing this. Will reopen and merge

@wnienhaus wnienhaus reopened this Dec 15, 2024
@wnienhaus wnienhaus merged commit f77a321 into micropython:master Dec 15, 2024
1 of 2 checks passed
@wnienhaus
Copy link
Collaborator

@pidou46 Thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants