Removed Application Insights

microsoft · Mar 28, 2016 · 736f9ab · 736f9ab
1 parent d8ff989
commit 736f9ab
Show file tree

Hide file tree

Showing 39 changed files with 65 additions and 711 deletions.
diff --git a/PhotoSharingApp/PhotoSharingApp.Universal.Tests/Services/ServiceClientTests.cs b/PhotoSharingApp/PhotoSharingApp.Universal.Tests/Services/ServiceClientTests.cs
@@ -23,7 +23,6 @@
 //  ---------------------------------------------------------------------------------
 
 using System.Threading.Tasks;
-using Microsoft.ApplicationInsights;
 using Microsoft.VisualStudio.TestPlatform.UnitTestFramework;
 using PhotoSharingApp.Universal.Services;
 
@@ -74,9 +73,7 @@ public async Task GetTopCategoriesTest()
         [TestInitialize]
         public void Init()
         {
-            var telemetryClient = new TelemetryClient();
-            _serviceClient = new ServiceClient(telemetryClient,
-                new AuthenticationHandler(telemetryClient));
+            _serviceClient = new ServiceClient(new AuthenticationHandler());
         }
     }
 }
diff --git a/PhotoSharingApp/PhotoSharingApp.Universal.Tests/Services/ServiceLoadTests.cs b/PhotoSharingApp/PhotoSharingApp.Universal.Tests/Services/ServiceLoadTests.cs
@@ -25,7 +25,6 @@
 using System;
 using System.Linq;
 using System.Threading.Tasks;
-using Microsoft.ApplicationInsights;
 using Microsoft.VisualStudio.TestPlatform.UnitTestFramework;
 using PhotoSharingApp.Universal.Models;
 using PhotoSharingApp.Universal.Services;
@@ -45,9 +44,7 @@ public class ServiceLoadTests
         [TestInitialize]
         public void Init()
         {
-            var telemetryClient = new TelemetryClient();
-            _serviceClient = new ServiceClient(telemetryClient,
-                new AuthenticationHandler(telemetryClient));
+            _serviceClient = new ServiceClient(new AuthenticationHandler());
             _configuration = new DefaultConfig();
         }
 

diff --git a/PhotoSharingApp/PhotoSharingApp.Universal/App.xaml.cs b/PhotoSharingApp/PhotoSharingApp.Universal/App.xaml.cs
@@ -25,13 +25,9 @@
 using System;
 using System.Runtime.CompilerServices;
 using System.Threading.Tasks;
-using Microsoft.ApplicationInsights;
 using Microsoft.Practices.ServiceLocation;
 using PhotoSharingApp.Universal.Facades;
 using PhotoSharingApp.Universal.Lifecycle;
-using PhotoSharingApp.Universal.Models;
-using PhotoSharingApp.Universal.ServiceEnvironments;
-using PhotoSharingApp.Universal.Telemetry;
 using PhotoSharingApp.Universal.Unity;
 using PhotoSharingApp.Universal.Views;
 using Windows.ApplicationModel;
@@ -57,11 +53,6 @@ public sealed partial class App : Application
         /// </summary>
         public App()
         {
-            WindowsAppInitializer.InitializeAsync(ServiceEnvironmentBase.Current.InstrumentationKey,
-                WindowsCollectors.Metadata
-                | WindowsCollectors.Session
-                | WindowsCollectors.UnhandledException);
-
             InitializeComponent();
 
             // Register for events
@@ -124,7 +115,7 @@ private async Task<AppShell> Initialize()
                 await AppInitialization.DoInitializations();
 
                 // Create a AppShell to act as the navigation context and navigate to the first page
-                shell = new AppShell(AppEnvironment.Instance.TelemetryClient);
+                shell = new AppShell();
 
                 // Set the default language
                 shell.Language = ApplicationLanguages.Languages[0];
@@ -143,9 +134,6 @@ protected override async void OnActivated(IActivatedEventArgs args)
         {
             base.OnActivated(args);
 
-            var telemetryClient = new TelemetryClient();
-            telemetryClient.TrackEvent(TelemetryEvents.AppOnNotificationActivated);
-
             var shell = Window.Current.Content as AppShell;
 
             // Check if the application needs to be initialized.
@@ -167,11 +155,6 @@ protected override async void OnActivated(IActivatedEventArgs args)
         /// <param name="e">Details about the launch request and process.</param>
         protected override async void OnLaunched(LaunchActivatedEventArgs e)
         {
-            // We have not configured our dependency container yet for the very first launch event, 
-            // so we create this instance manually.
-            var telemetryClient = new TelemetryClient();
-            telemetryClient.TrackEvent(TelemetryEvents.AppOnLaunch);
-
             var shell = await Initialize();
 
             // Place our app shell in the current Window
@@ -233,9 +216,6 @@ private async void OnUnhandledException(object sender, UnhandledExceptionEventAr
         {
             e.Handled = true;
 
-            var telemetryClient = new TelemetryClient();
-            telemetryClient.TrackException(e.Exception);
-
             var resourceLoader = ResourceLoader.GetForCurrentView();
             var dialog = new MessageDialog(resourceLoader.GetString("UnexpectedError_Message"),
                 resourceLoader.GetString("UnexpectedError_Title"));

diff --git a/PhotoSharingApp/PhotoSharingApp.Universal/AppShareTarget.cs b/PhotoSharingApp/PhotoSharingApp.Universal/AppShareTarget.cs
@@ -24,13 +24,11 @@
 
 using System;
 using System.Linq;
-using Microsoft.ApplicationInsights;
 using Microsoft.Practices.ServiceLocation;
 using Microsoft.Practices.Unity;
 using PhotoSharingApp.Universal.Facades;
 using PhotoSharingApp.Universal.Lifecycle;
 using PhotoSharingApp.Universal.Models;
-using PhotoSharingApp.Universal.Telemetry;
 using PhotoSharingApp.Universal.Unity;
 using PhotoSharingApp.Universal.ViewModels;
 using Windows.ApplicationModel.Activation;
@@ -73,9 +71,6 @@ private Frame GetOrCreateRootFrame()
         /// <param name="args">Event data for the event.</param>
         protected override async void OnShareTargetActivated(ShareTargetActivatedEventArgs args)
         {
-            var telemetryClient = new TelemetryClient();
-            telemetryClient.TrackEvent(TelemetryEvents.AppOnShareTargetActivated);
-
             IAppEnvironment mainAppEnvironment = null;
             IUploadFinishedHandler mainUploadFinishedHandler = null;
 
@@ -146,10 +141,8 @@ protected override async void OnShareTargetActivated(ShareTargetActivatedEventAr
                         Window.Current.Activate();
                     }
                 }
-                catch (Exception exception)
+                catch (Exception)
                 {
-                    telemetryClient.TrackException(exception);
-
                     args.ShareOperation.ReportCompleted();
                 }
             }

diff --git a/PhotoSharingApp/PhotoSharingApp.Universal/Camera/CameraEngine.cs b/PhotoSharingApp/PhotoSharingApp.Universal/Camera/CameraEngine.cs
@@ -27,7 +27,6 @@
 using System.Diagnostics;
 using System.Linq;
 using System.Threading.Tasks;
-using Microsoft.ApplicationInsights;
 using PhotoSharingApp.Universal.ComponentModel;
 using PhotoSharingApp.Universal.Editing;
 using PhotoSharingApp.Universal.Extensions;
@@ -87,16 +86,6 @@ public class CameraEngine : ObservableObjectBase, ICameraEngine
         /// </summary>
         private VideoEncodingProperties _selectedPreviewResolution;
 
-        /// <summary>
-        /// The telemetry client.
-        /// </summary>
-        private readonly TelemetryClient _telemetryClient;
-
-        public CameraEngine(TelemetryClient telemetryClient)
-        {
-            _telemetryClient = telemetryClient;
-        }
-
         /// <summary>
         /// Gets a value indicating whether multiple cameras are available.
         /// </summary>
@@ -266,7 +255,6 @@ public async Task InitCamera(DeviceInformation deviceInformation = null)
             }
             else
             {
-                _telemetryClient.TrackTrace("No camera detected");
                 throw new CameraNotFoundException();
             }
         }
@@ -354,10 +342,6 @@ public async Task StopPreviewAsync()
                 await _mediaCapture.StopPreviewAsync();
                 IsPreviewing = false;
             }
-            else
-            {
-                _telemetryClient.TrackTraceWithCallerName("mediaCapture is null");
-            }
         }
 
         /// <summary>

diff --git a/PhotoSharingApp/PhotoSharingApp.Universal/Extensions/TelemetryClientExtensions.cs b/PhotoSharingApp/PhotoSharingApp.Universal/Extensions/TelemetryClientExtensions.cs
diff --git a/PhotoSharingApp/PhotoSharingApp.Universal/Facades/LicensingFacade.cs b/PhotoSharingApp/PhotoSharingApp.Universal/Facades/LicensingFacade.cs
@@ -22,14 +22,10 @@
 //  ---------------------------------------------------------------------------------
 
 using System;
-using System.Collections.Generic;
 using System.Threading.Tasks;
-using Microsoft.ApplicationInsights;
-using PhotoSharingApp.Universal.Extensions;
 using PhotoSharingApp.Universal.Models;
 using PhotoSharingApp.Universal.Services;
 using PhotoSharingApp.Universal.Store;
-using PhotoSharingApp.Universal.Telemetry;
 using Windows.ApplicationModel.Store;
 
 namespace PhotoSharingApp.Universal.Facades
@@ -49,15 +45,9 @@ public class LicensingFacade : ILicensingFacade
         /// </summary>
         private readonly IPhotoService _photoService;
 
-        /// <summary>
-        /// The telemetry client.
-        /// </summary>
-        private readonly TelemetryClient _telemetryClient;
-
-        public LicensingFacade(TelemetryClient telemetryClient, IPhotoService photoService,
+        public LicensingFacade(IPhotoService photoService,
             IAuthEnforcementHandler authEnforcementHandler)
         {
-            _telemetryClient = telemetryClient;
             _photoService = photoService;
             _authEnforcementHandler = authEnforcementHandler;
         }
@@ -73,8 +63,6 @@ public LicensingFacade(TelemetryClient telemetryClient, IPhotoService photoServi
         /// </remarks>
         private async Task DoFulfillment()
         {
-            _telemetryClient.TrackEvent(TelemetryEvents.DoFullfillment);
-
             var productLicenses = CurrentAppProxy.LicenseInformation.ProductLicenses;
 
             // Do fulfillment of all avalaible IAPs.
@@ -95,17 +83,8 @@ public async Task PurchaseGold(string productId)
         {
             await _authEnforcementHandler.CheckUserAuthentication();
 
-            _telemetryClient.TrackEvent(TelemetryEvents.PurchaseGoldInitiated,
-                TelemetryProperties.ProductId, productId);
-
             // Kick off the purchase
             var purchaseResults = await CurrentAppProxy.RequestProductPurchaseAsync(productId);
-            _telemetryClient.TrackEvent(TelemetryEvents.PurchaseGoldPurchaseResultsAvailable,
-                new Dictionary<string, string>
-                {
-                    { TelemetryProperties.ProductId, productId },
-                    { TelemetryProperties.PurchaseStatus, purchaseResults.Status.ToString() }
-                });
 
             if (purchaseResults.Status == ProductPurchaseStatus.Succeeded
                 || purchaseResults.Status == ProductPurchaseStatus.NotFulfilled)
@@ -138,16 +117,6 @@ private async Task TryFulfillGold(ProductLicense productLicense)
 
                 // Now update local gold balance
                 AppEnvironment.Instance.CurrentUser.GoldBalance = user.GoldBalance;
-
-                _telemetryClient.TrackEvent(TelemetryEvents.PurchaseGoldSuccess);
-            }
-            else
-            {
-                _telemetryClient.TrackEvent(TelemetryEvents.PurchaseGoldFail,
-                    new Dictionary<string, string>
-                    {
-                        { TelemetryProperties.ProductId, productLicense.ProductId }
-                    });
             }
         }
     }

diff --git a/PhotoSharingApp/PhotoSharingApp.Universal/Facades/NavigationFacade.cs b/PhotoSharingApp/PhotoSharingApp.Universal/Facades/NavigationFacade.cs
@@ -27,7 +27,6 @@
 using System.Reflection;
 using System.Runtime.Serialization;
 using System.Threading.Tasks;
-using Microsoft.ApplicationInsights;
 using PhotoSharingApp.Universal.Extensions;
 using PhotoSharingApp.Universal.Models;
 using PhotoSharingApp.Universal.Serialization;
@@ -55,20 +54,6 @@ public class NavigationFacade : INavigationFacade
         /// </summary>
         private Frame _frame;
 
-        /// <summary>
-        /// The telemetry client.
-        /// </summary>
-        private readonly TelemetryClient _telemetryClient;
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="NavigationFacade" /> class.
-        /// </summary>
-        /// <param name="telemetryClient">The telemetry client.</param>
-        public NavigationFacade(TelemetryClient telemetryClient)
-        {
-            _telemetryClient = telemetryClient;
-        }
-
         /// <summary>
         /// Determines if back navigation
         /// </summary>
@@ -424,10 +409,9 @@ public void RemoveUploadPhotoFramesFromBackStack(string categoryIdNavigatedTo)
                                 framesToRemove++;
                             }
                         }
-                        catch (SerializationException e)
+                        catch (SerializationException)
                         {
-                            // Swallow exception.  Args were of different type than expected.
-                            _telemetryClient.TrackException(e);
+                            // Swallow exception. Args were of different type than expected.
                         }
                     }