Added M365 connections to shared #2090
Conversation
|
We should also look into adding pester testing here as well. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| [Parameter(Mandatory = $false)] | ||
| [System.Version]$MinModuleVersion = $null |
There was a problem hiding this comment.
I guess we did address this by being in a loop, but the chances of you having a module that you are requesting be at the same min version is pretty low.
Shared/ModuleHandle.ps1
Outdated
| } | ||
| $installed = Get-InstalledModule @getParams | ||
|
|
||
| if ($null -eq $installed -or $installed.Name -notcontains $module) { |
There was a problem hiding this comment.
If we did find the module with the version that we are looking for, we should do Write-Verbose here that states at least the version to know if it is something newer and possibly something changed with the cmdlets that broke something.
There was a problem hiding this comment.
@iserrano76 let's do this and rebase and then we should be good for one last review before merge.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Shared/ModuleHandle.ps1
Outdated
| @@ -29,19 +29,18 @@ function Request-Module { | |||
| [OutputType([bool])] | |||
| param ( | |||
| [Parameter(Mandatory = $true)] | |||
| [string[]]$Modules, | |||
| [string[]]$Module, | |||
| [Parameter(Mandatory = $false)] | |||
| [System.Version]$MinModuleVersion = $null | |||
| ) | |||
|
|
|||
| $noFoundError = $true | |||
| foreach ($module in $Modules) { | |||
There was a problem hiding this comment.
You broke this loop because you changed the parameter name to be $Module instead of $Modules.
There was a problem hiding this comment.
Thanks for point to this, I am modifying the parameter to singular as you recommend in a previous PR from the Development Guidelines.
I will fix this and rebase
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@iserrano76 let's go ahead and rebase and squash this down to a single commit. |
Issue:
Added two functions to Shared in case any script needs a connection to M365.
One function for Exchange Online another function for AzureAD
Reason:
Unify the way we connect to M365.
Fix:
Both functions will do the following:
Important: we do not disconnect at anytime we just verify if we have an active session