Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic v2 migration #5167

Merged
merged 68 commits into from
Aug 22, 2024
Merged

Pydantic v2 migration #5167

merged 68 commits into from
Aug 22, 2024

Conversation

mrwyattii
Copy link
Contributor

@mrwyattii mrwyattii commented Feb 21, 2024

Pydantic v2 has been out for some time now. We have been relying on using the v1 API available in v2 until now. This is a refresh of #3902 to bring proper v2 support to DeepSpeed.

Corresponding DeepSpeed-MII PR here.

@loadams

@loadams
Copy link
Contributor

loadams commented Feb 27, 2024

Do you want to do what we did on the previous pydantic update of updating the nv-mii test to use your branch rather than main so that it passes here?

@mrwyattii
Copy link
Contributor Author

CI with microsoft/DeepSpeed-MII#423 for nv-a6000 and nv-mii

@loadams
Copy link
Contributor

loadams commented Jul 1, 2024

CI triggered using updates in MII

nv-a6000
nv-mii

Both tests now passing.

@loadams
Copy link
Contributor

loadams commented Aug 20, 2024

Tested in #6382.

@loadams loadams merged commit 0a4457c into master Aug 22, 2024
15 of 18 checks passed
weiji14 added a commit to regro-cf-autotick-bot/deepspeed-feedstock that referenced this pull request Aug 23, 2024
weiji14 added a commit to conda-forge/deepspeed-feedstock that referenced this pull request Aug 29, 2024
* updated v0.15.0

* MNT: Re-rendered with conda-build 24.7.1, conda-smithy 3.38.0, and conda-forge-pinning 2024.08.23.00.41.48

* Remove ninja as runtime dependency

Xref #1

* Remove note about pydantic<2.0.0 pin

Since microsoft/DeepSpeed#5167 is merged already.

---------

Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants