Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Error Handling] Fix DxcContainerBuilder error handling #7056

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Error Handling] Fix DxcContainerBuilder error handling #7056

wants to merge 8 commits into from
+65 −16

Conversation

bob80905
Copy link
Collaborator

Some error handling changes were incorrectly made to the container assembler, as described in the issue below.
This is bad because the API protocol for error handling must remain consistent across all functions. This PR
aims to restore the correct semantic meaning of returning bad HR values.
Fixes #7051

@bob80905 bob80905 requested a review from a team as a code owner January 11, 2025 00:51
tex3d
tex3d requested changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this succeeded testing without the suggested change to check valHR before hashing, we are missing a test that makes sure it doesn't hash the shader even when validation fails.

lib/DxilContainer/DxcContainerBuilder.cpp Outdated Show resolved Hide resolved
lib/DxilContainer/DxcContainerBuilder.cpp Outdated Show resolved Hide resolved
@bob80905 bob80905 self-assigned this Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

tex3d
tex3d approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tex3d tex3d tex3d approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@bob80905 bob80905

Labels
None yet
Projects
HLSL Roadmap
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in ContainerBuilder error handling code introduced by #6853
2 participants
@bob80905 @tex3d