[SER] Patch 1: HitObject type lowering and SM 6.9 enablement #7097
Conversation
Reduction of the complete SER implementation to just the HitObject type and its default constructor. Specification PR: microsoft/hlsl-specs#277
|
@microsoft-github-policy-service agree company="NVIDIA" |
When specifying more than four stages in a PAQ, the
SmallVector in the PayloadAccessAnnotation starts to allocate memory.
That memory is never free'd.
The hitobject-entry-errors accidentally triggered this:
struct [raypayload] Payload
{
float elem
- : write(caller,closesthit,anyhit,closesthit,miss)
- : read(caller,closesthit,anyhit,closesthit,miss);
+ : write(caller,anyhit,closesthit,miss)
+ : read(caller,anyhit,closesthit,miss);
};
| @@ -613,6 +613,22 @@ bool IsHLSLResourceType(clang::QualType type) { | |||
| return false; | |||
| } | |||
|
|
|||
| bool IsHLSLHitObjectType(QualType type) { | |||
There was a problem hiding this comment.
There's already a IsHLSLHitObjectTy in DxilUtil.cpp. Though I know this functions differently, I would think getting the underlying Type object within QualType, and then calling IsHLSLHitObjectTy on that, would return a sensible result. Because that isn't the implementation, would you be able to update the function names so that they're different?
There was a problem hiding this comment.
The patch uses the same naming and implementation approach for HitObject as was done for NodeOutput and RayQuery. The name IsHLSLHitObjectType says what the function does not how it is implemented, so i don't find that argument very convincing.
Do we really want to change this?
tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject-entry-errors.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject-in-buffer.hlsl
Outdated
Show resolved
Hide resolved
Reduction of the complete SER implementation to just the HitObject type and its default constructor.
This has most of the infrastructure changes in DXC to support SER, eg static member functions for builtins, HitObject scalar type.
Specification PR: microsoft/hlsl-specs#277