Code review for Mouse CoreWindow implementation

[DJm00n]

Use USER_DEFAULT_SCREEN_DPI define instead of 96 value.

[walbourn]

The symbol USER_DEFAULT_SCREEN_DPI is indeed 96 which is how it is defined. The problem is that for UWP, this constant is NOT defined and that's the "CoreWindow" implementation that is using the value.

See winuser.h:

#pragma region Desktop Family
#if WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP)

WINUSERAPI
BOOL
WINAPI
GetGUIThreadInfo(
    _In_ DWORD idThread,
    _Inout_ PGUITHREADINFO pgui);

WINUSERAPI
BOOL
WINAPI
BlockInput(
    BOOL fBlockIt);

#if(_WIN32_WINNT >= 0x0600)

#define USER_DEFAULT_SCREEN_DPI 96

[walbourn]

One solution here is I think that I Just define USER_DEFAULT_SCREEN_DPI for the CoreWindow implementation since that define is never set for that context.

I agree that 'magic number' approach is less clear so that is a good improvement. For all the UWP examples, they just use '96'.

[walbourn]

Note that VCPKG checks fail as that pipeline requires a GHA variable which is limited due to security for PRs coming from external contributors. The code builds fine for that case.