Skip to content

Commit

Permalink
Increase snapshotRefreshTimeoutMs for non local drivers on e2e tests (#…
Browse files Browse the repository at this point in the history
…22871)

Refresh snapshot lifecycle tests are having timeout issues while running
them against FRS and ODSP drivers. On debugging I was able to detect a
throttling error while requesting updating the snapshot since the
timeout to request a new snapshot was too short. On increasing such
timeout to 1sec instead of 100ms, the throttling error disappear
completely on local tests while running against ODSP without impacting
on test duration (this could be subject to further calibration).

My hypothesis is that while running on the lab, snapshot refresh fails
silently, and given we never refreshed, our deferred promises that
awaits for it never resolves, ending in the timeout.
  • Loading branch information
dannimad authored Oct 23, 2024
1 parent 7405cf5 commit 4b8d1c5
Showing 1 changed file with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ describeCompat("Refresh snapshot lifecycle", "NoCompat", (getTestObjectProvider,
) {
return;
}
let snapshotRefreshTimeoutMs;
if (
testConfig.timeoutRefreshInOriginalContainer ||
testConfig.timeoutRefreshInLoadedContainer
) {
snapshotRefreshTimeoutMs = provider.driver.type === "local" ? 100 : 1000;
}
const getLatestSnapshotInfoP = new Deferred<void>();
const testContainerConfig = {
fluidDataObjectType: DataObjectFactoryType.Test,
Expand All @@ -186,11 +193,7 @@ describeCompat("Refresh snapshot lifecycle", "NoCompat", (getTestObjectProvider,
"Fluid.Container.enableOfflineSnapshotRefresh": true,
"Fluid.Container.UseLoadingGroupIdForSnapshotFetch":
testConfig.useLoadingGroupIdForSnapshotFetch,
"Fluid.Container.snapshotRefreshTimeoutMs":
testConfig.timeoutRefreshInOriginalContainer ||
testConfig.timeoutRefreshInLoadedContainer
? 100
: undefined,
"Fluid.Container.snapshotRefreshTimeoutMs": snapshotRefreshTimeoutMs,
}),
},
};
Expand Down

0 comments on commit 4b8d1c5

Please sign in to comment.